Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generative vignette #24

Merged
merged 24 commits into from
Oct 16, 2024
Merged

Generative vignette #24

merged 24 commits into from
Oct 16, 2024

Conversation

Accio
Copy link
Contributor

@Accio Accio commented Aug 22, 2023

Dear colleagues,

I have added a vignette using a simple generative model to show the benefit of randomization.

If you think the approach makes sense, I plan to add another 1-2 case studies, using more functionalities in our package, to make the case. Before I do that, please check out the simple example, and let me know what you think (example, coding style, wording, etc.). Criticism and suggestions are highly welcome.

Best regards, David

@idavydov idavydov self-requested a review August 22, 2023 15:33
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
@julianesiebourg julianesiebourg added the documentation Improvements or additions to documentation label Sep 4, 2023
@julianesiebourg
Copy link
Collaborator

Hi @Accio,
thank you for the nicely written example. Clearly, so far a simulation example was missing.
I like how you plot the different effects on the readouts separately and then on-top of each other.

One thing I was wondering is whether we, in addition to the benefit of randomization, also show the benefit of blocking?
We can use the optimize_design function to ensure that most treatments cover most rows and columns (e.g. the randomization is really efficient), and thus get even less bias from the plate effect.
Maybe in your example it does not make much of a difference, but if the randomization is 'unlucky' you could still get many samples of Compound1 in the same column and due to the plate gradient still draw wrong conclusions.
What do you think?
I'm happy to add that part!

@Accio
Copy link
Contributor Author

Accio commented Sep 4, 2023

Thank you for the kind words! Yes, your proposal makes perfect sense. Please do it.

I planned indeed to expand on the simple example. If you take over the blocking part, then I may contribute the next level: namely adding an operator/plate-batch effect on the top. Does that make sense? I can build then on what you have built.

Best regards and thanks again for the encouraging words.

@julianesiebourg
Copy link
Collaborator

Thanks David, yes, I'll add that part!

@julianesiebourg julianesiebourg linked an issue Sep 6, 2023 that may be closed by this pull request
Copy link
Collaborator

@julianesiebourg julianesiebourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi David sorry, for the delay, I didn't notice I didn't submit my suggestions!!

vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
vignettes/generative_necessity.Rmd Outdated Show resolved Hide resolved
Copy link
Contributor Author

@Accio Accio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

DESCRIPTION Outdated Show resolved Hide resolved
vignettes/osat.Rmd Outdated Show resolved Hide resolved
@idavydov
Copy link
Collaborator

idavydov commented Oct 1, 2024

hi @julianesiebourg, I went through the vignette and updated it in accordance with the designit style.

I use a function to generate data with batch effects based on a batch container.

could you please let me know what you think?

Copy link
Collaborator

@julianesiebourg julianesiebourg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks very nice now, also easily extendible for other effects/ situations.

vignettes/basic_examples.Rmd Outdated Show resolved Hide resolved
vignettes/basic_examples.Rmd Outdated Show resolved Hide resolved
vignettes/basic_examples.Rmd Outdated Show resolved Hide resolved
Co-authored-by: julianesiebourg <[email protected]>
@idavydov idavydov merged commit f4970d7 into main Oct 16, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expand generative model vignette with simple optimize design call
3 participants