-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generative vignette #24
Conversation
Hi @Accio, One thing I was wondering is whether we, in addition to the benefit of randomization, also show the benefit of blocking? |
Thank you for the kind words! Yes, your proposal makes perfect sense. Please do it. I planned indeed to expand on the simple example. If you take over the blocking part, then I may contribute the next level: namely adding an operator/plate-batch effect on the top. Does that make sense? I can build then on what you have built. Best regards and thanks again for the encouraging words. |
Thanks David, yes, I'll add that part! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi David sorry, for the delay, I didn't notice I didn't submit my suggestions!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Co-authored-by: julianesiebourg <[email protected]>
ed7de70
to
75b7d99
Compare
hi @julianesiebourg, I went through the vignette and updated it in accordance with the I use a function to generate data with batch effects based on a batch container. could you please let me know what you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it looks very nice now, also easily extendible for other effects/ situations.
Co-authored-by: julianesiebourg <[email protected]>
Dear colleagues,
I have added a vignette using a simple generative model to show the benefit of randomization.
If you think the approach makes sense, I plan to add another 1-2 case studies, using more functionalities in our package, to make the case. Before I do that, please check out the simple example, and let me know what you think (example, coding style, wording, etc.). Criticism and suggestions are highly welcome.
Best regards, David